Make it easier to set a page title

[nataliecarey]

@frankieroberto contributed a PR for this with the comment "One possible implementation for #1975."

I have taken that PR, added tests and changed the behaviour slightly. It now works as follows:

• You can override the pageTitle block (as we have recommended so far) which gives you full control over the page title.
• You can set a pageName variable and the title will have - <serviceName> - GOV.UK added to the end of it

Next steps:

• @frankieroberto can you check my PR and make sure it's in line with your expectations.
• @joelanman and @oli-rose28 can you take a look and see if this is behaviour we want to add to the kit - note I've updated the dash character to match Frankie's PR, I'm not sure which dash is right and which one is wrong but I've avoided a mismatch. If I've gone the wrong way feel free to change all the dashes in this PR to the correct type.

[frankieroberto]

Looks great to me! I'm not actually sure which of the many dash characters should be used, but GOV.UK seems to use - (hyphen-minus)? Probably an — (em dash) would look better, but maybe there’s a reason not to use this? 🤷

As a follow-up PR, we could set the title variable on the example template pages, and then re-use the title within the h1s?

[frankieroberto]

I’m not actually sure if titleOrganisation is needed? I've not seen anyone use that format and it’s not mentioned in the title style guide - but maybe you know of some instances?

[nataliecarey]

The reason I put that in is because we use - GOV.UK Prototype Kit and your example was - GOV.UK.

I took that to mean that you want titles in your prototype to end with - GOV.UK but I don't think we can recommend that as a default, so in your kit you can set titleOrganisation = "GOV.UK" and get the behaviour that was in your PR before I messed with it.

[nataliecarey]

Also, I fixed the dash to match what's on the style guide (probably what we were already using).

[frankieroberto]

Wouldn’t that still result in Section name - GOV.UK - GOV.UK Prototype Kit though? I think we’d want to use Section name - service name - GOV.UK, as per the style guide?

Is there any reason not to switch out GOV.UK Prototype Kit for GOV.UK as the hardcoded bit at the end? The prototypes are password-protected, and otherwise look and feel exactly like a real service, so I don't see any issues around accidentally misleading people?

[frankieroberto]

Oops I misread the syntax! 🤦🏻‍♂️

I still think you could default to just - GOV.UK but it’s not a big deal.

Would also suggest renaming the variable to titleSuffix to be more generic, as I don’t think it’s generally recommended to include the organisation (eg department) name in the title?

[joelanman]

Agree the default should be GOV.UK as per our guidelines

[joelanman]

decided to drop org/suffix - this is the govuk branded template - the default should be GOV.UK. If we find use cases to change it we can investigate adding suffix then

[frankieroberto]

🙌🏻