Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support html and njk extensions #2035

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Support html and njk extensions #2035

merged 2 commits into from
Mar 15, 2023

Conversation

ollie-b-gds
Copy link
Contributor

See: Support for .njk extension

  • Allows .html and .njk to be used interchangeably
  • The default for creating views from templates will be .html, but .njk will be used if the app/config.json contains "useNjkExtensions": true.
  • If two views in the same location with the same name but with different suffixes (html or njk), the default suffix (determined by the existence of the useNjkExtensions setting above) will be matched first followed by the alternative.

@ollie-b-gds ollie-b-gds linked an issue Mar 13, 2023 that may be closed by this pull request
Support for .njk extension #1719
Closed
@ollie-b-gds @BenSurgisonGDS
@HannahJMWood @nataliecarey
Support html and njk extensions
2d58d5f 
Co-authored-by: Ben Surgison <ben.surgison@digital.cabinet-office.gov.uk>
Co-authored-by: Hannah Wood <hannah.wood@digital.cabinet-office.gov.uk>
Co-authored-by: Natalie Carey <natalie.carey@digital.cabinet-office.gov.uk>
HannahJMWood
HannahJMWood reviewed Mar 15, 2023
View reviewed changes
__tests__/utils/index.js Show resolved Hide resolved
cypress/events/index.js Outdated Show resolved Hide resolved
lib/build.js Outdated Show resolved Hide resolved
lib/nunjucks/nunjucksLoader.js Show resolved Hide resolved
@ollie-b-gds ollie-b-gds merged commit d034ca5 into main Mar 15, 2023
@ollie-b-gds ollie-b-gds deleted the support-html-and-njk-extension branch March 15, 2023 12:21
@BenSurgisonGDS BenSurgisonGDS mentioned this pull request Mar 16, 2023
Merged
@HannahJMWood HannahJMWood mentioned this pull request Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HannahJMWood HannahJMWood HannahJMWood approved these changes

@BenSurgisonGDS BenSurgisonGDS Awaiting requested review from BenSurgisonGDS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for .njk extension
2 participants
@ollie-b-gds @HannahJMWood