Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update extends unbranded correctly during migrate #2050

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Update extends unbranded correctly during migrate #2050

merged 1 commit into from
Mar 20, 2023

Conversation

BenSurgisonGDS
Copy link
Contributor

@BenSurgisonGDS BenSurgisonGDS commented Mar 17, 2023 •
edited
Loading

See Migration script doesn't update extends lines

  • All occurences of "layout_unbranded.html" within the nunjucks files in the users app folder will be replaced with "govuk-prototype-kit/layouts/unbranded.html" during the migration process.

@BenSurgisonGDS BenSurgisonGDS self-assigned this Mar 17, 2023
@BenSurgisonGDS BenSurgisonGDS linked an issue Mar 17, 2023 that may be closed by this pull request
Migration script doesn't update extends lines #1842
Closed
@BenSurgisonGDS BenSurgisonGDS force-pushed the update-extends-unbranded-correctly-during-migrate branch from c8771ec to 6b7a848 Compare March 17, 2023 14:22
@BenSurgisonGDS BenSurgisonGDS merged commit a903b91 into main Mar 20, 2023
@BenSurgisonGDS BenSurgisonGDS deleted the update-extends-unbranded-correctly-during-migrate branch March 20, 2023 09:43
@HannahJMWood HannahJMWood mentioned this pull request Mar 31, 2023
Merged
@joanjoantan joanjoantan mentioned this pull request Dec 28, 2023
Open
@johndenford johndenford mentioned this pull request Dec 28, 2023
Open
@joanjoantan joanjoantan mentioned this pull request Jan 5, 2024
Open
@Will-Trust Will-Trust mentioned this pull request Jan 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HannahJMWood HannahJMWood HannahJMWood approved these changes

@ollie-b-gds ollie-b-gds Awaiting requested review from ollie-b-gds

@joelanman joelanman Awaiting requested review from joelanman

Assignees

@BenSurgisonGDS BenSurgisonGDS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migration script doesn't update extends lines
2 participants
@BenSurgisonGDS @HannahJMWood