Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating page titles for template pages. #2085

Merged
merged 5 commits into from
Apr 5, 2023
Merged

Conversation

nataliecarey
Copy link
Contributor

Fix for #1952

lib/manage-prototype-handlers.js Outdated Show resolved Hide resolved
@joelanman
Copy link
Contributor

needs a changelog

@nataliecarey
Copy link
Contributor Author

I've updated the titles and re-used them for the <h1> to ensure they're in sync.

@nataliecarey
Copy link
Contributor Author

@joelanman I've made a few changes because I broke the highlight on the Templates nav item when I changed the title.

The title now includes - Templates as well as the page name e.g.

Page created - Templates - Manage your prototype - Service name goes here - GOV.UK Prototype Kit

It makes it pretty long, I can remove that if that's not wanted.

@joelanman
Copy link
Contributor

I thought about it but it does make it long, and I think the titles are clear without it, I don't think we need 'Templates' in the title

@nataliecarey
Copy link
Contributor Author

I've taken out the Templates - part of the title e.g.

Page created - Manage your prototype - Service name goes here - GOV.UK Prototype Kit

I've also added to the CHANGELOG.

Copy link
Contributor

@joelanman joelanman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

Copy link
Contributor

@BenSurgisonGDS BenSurgisonGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nataliecarey nataliecarey merged commit beedf23 into main Apr 5, 2023
@nataliecarey nataliecarey deleted the template-page-titles branch April 5, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants