Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show an error in the browser when the kit couldn't start #2101

Merged
merged 6 commits into from
May 9, 2023
Merged

Show an error in the browser when the kit couldn't start #2101

merged 6 commits into from
May 9, 2023

Conversation

nataliecarey
Copy link
Contributor

An implementation of #2090

@nataliecarey nataliecarey force-pushed the show-500-when-server-cant-start branch 2 times, most recently from dac24b0 to dac8f17 Compare April 12, 2023 00:43
BenSurgisonGDS
BenSurgisonGDS previously requested changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@BenSurgisonGDS BenSurgisonGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a cypress test to load the home page, break the index.njk template, prove the error server is displaying the 500 error, fix the index.njk template, prove the page loads again.

@nataliecarey nataliecarey force-pushed the show-500-when-server-cant-start branch 2 times, most recently from 104bb52 to 0b8f1dc Compare April 12, 2023 11:00
@nataliecarey nataliecarey force-pushed the show-500-when-server-cant-start branch from 0b8f1dc to e45d6a8 Compare April 12, 2023 11:02
@nataliecarey nataliecarey force-pushed the show-500-when-server-cant-start branch from ccd8539 to bc1e346 Compare May 2, 2023 12:22
@nataliecarey nataliecarey force-pushed the show-500-when-server-cant-start branch from bc1e346 to c62fa5b Compare May 2, 2023 12:57
@nataliecarey nataliecarey force-pushed the show-500-when-server-cant-start branch from d8980db to 1bd1b42 Compare May 9, 2023 10:16
@nataliecarey nataliecarey dismissed BenSurgisonGDS’s stale review May 9, 2023 11:16

There is now a Cypress test.

BenSurgisonGDS
BenSurgisonGDS approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@BenSurgisonGDS BenSurgisonGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@nataliecarey nataliecarey merged commit 884c50c into main May 9, 2023
@nataliecarey nataliecarey deleted the show-500-when-server-cant-start branch May 9, 2023 15:54
@nataliecarey nataliecarey mentioned this pull request May 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenSurgisonGDS BenSurgisonGDS BenSurgisonGDS approved these changes

@ollie-b-gds ollie-b-gds Awaiting requested review from ollie-b-gds

@HannahJMWood HannahJMWood Awaiting requested review from HannahJMWood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nataliecarey @BenSurgisonGDS