Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent CSURF deprecated warning #2150

Merged
merged 3 commits into from
May 5, 2023
Merged

Prevent CSURF deprecated warning #2150

merged 3 commits into from
May 5, 2023

Conversation

BenSurgisonGDS
Copy link
Contributor

@BenSurgisonGDS BenSurgisonGDS commented May 2, 2023 •
edited
Loading

See: Fix our CSRF vulnerability

  • Replace CSURF implementation with CSRF-CSRF implementation
  • Make sure cookie-parser middleware is after express-session middleware as recommended here
  • Fix unit tests
  • Fix acceptance tests

@BenSurgisonGDS BenSurgisonGDS linked an issue May 2, 2023 that may be closed by this pull request
Fix our CSRF vulnerability #2129
Closed
@BenSurgisonGDS BenSurgisonGDS self-assigned this May 2, 2023
@BenSurgisonGDS BenSurgisonGDS marked this pull request as ready for review May 2, 2023 13:42
@BenSurgisonGDS BenSurgisonGDS changed the title Initial commit Prevent CSURF deprecated warning May 2, 2023
@BenSurgisonGDS BenSurgisonGDS merged commit 21fd1c8 into main May 5, 2023
@BenSurgisonGDS BenSurgisonGDS deleted the 2129-fix-our-csrf-vulnerability branch May 5, 2023 10:04
@nataliecarey nataliecarey mentioned this pull request May 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HannahJMWood HannahJMWood HannahJMWood approved these changes

@nataliecarey nataliecarey Awaiting requested review from nataliecarey

@ollie-b-gds ollie-b-gds Awaiting requested review from ollie-b-gds

Assignees

@BenSurgisonGDS BenSurgisonGDS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix our CSRF vulnerability
2 participants
@BenSurgisonGDS @HannahJMWood