Get live reloading working with the error screen #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
BenSurgisonGDS
force-pushed
the
2091-get-live-reloading-working-within-the-error-screen
branch
3 times, most recently
from
60a5272
to
4427ded
Compare
BenSurgisonGDS
force-pushed
the
2091-get-live-reloading-working-within-the-error-screen
branch
from
5f1a6fa
to
7f166b6
Compare
BenSurgisonGDS
force-pushed
the
2091-get-live-reloading-working-within-the-error-screen
branch
from
9561494
to
788586a
Compare
BenSurgisonGDS
force-pushed
the
2091-get-live-reloading-working-within-the-error-screen
branch
from
13c333e
to
b199641
Compare
| @@ -5,3 +5,15 @@ | |||
| <script src="{{scriptConfig.src}}"></script> | |||
| {% endif %} | |||
| {% endfor %} | |||
|
|
|||
| <script> | |||
| document.addEventListener('DOMContentLoaded', function () { | |||
There was a problem hiding this comment.
Can we put this in its own js file please?
nataliecarey
approved these changes
May 15, 2023
BenSurgisonGDS
deleted the
2091-get-live-reloading-working-within-the-error-screen
branch
|
does this need a changelog? |
|
It has a changelog entry, that seems appropriate to me. |
|
oh sorry my mistake, missed it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Get live reloading working within the error screen