Hiding govuk-frontend uninstall until we deal with dependent plugins #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nataliecarey
force-pushed
the
hiding-govuk-frontend-uninstall
branch
from
f386e53
to
15e9f87
Compare
BenSurgisonGDS
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #2171 we don't have an optimal UI experience for uninstalling
govuk-frontendright now so we are removing the button. The kit still works withoutgovuk-frontendas long as no other plugins expect it to be there.In this PR I've made the button available when a feature flag is set - either
allowGovukFrontendUninstallin theconfig.jsonorALLOW_GOVUK_FRONTEND_UNINSTALLin the environment variables. This is mostly to preserve the functionality and tests so that we can prove that the kit works without frontend. It can be used by users too but we shouldn't be recommending that they use it.