Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the design of the error screen #2183

Merged
merged 12 commits into from
May 25, 2023
Merged

Improve the design of the error screen #2183

merged 12 commits into from
May 25, 2023

Conversation

BenSurgisonGDS
Copy link
Contributor

@BenSurgisonGDS BenSurgisonGDS commented May 18, 2023 •
edited
Loading

See: Improve the design of errors

  • Parse error messages and format for display within the error page
  • Amend Cypress tests
  • Amend Unit tests

@BenSurgisonGDS BenSurgisonGDS linked an issue May 18, 2023 that may be closed by this pull request
Improve the design of errors #2019
Open
3 tasks
@BenSurgisonGDS BenSurgisonGDS force-pushed the 2019-improve-the-design-of-errors branch from dc54d5f to b960a9b Compare May 19, 2023 09:45
@BenSurgisonGDS BenSurgisonGDS marked this pull request as ready for review May 19, 2023 14:46
@BenSurgisonGDS BenSurgisonGDS force-pushed the 2019-improve-the-design-of-errors branch from 84e740c to 9239fea Compare May 23, 2023 10:07
@BenSurgisonGDS BenSurgisonGDS changed the title 2019 improve the design of errors Improve the design of errors May 23, 2023
@BenSurgisonGDS BenSurgisonGDS changed the title Improve the design of errors Improve the design of the error screen May 23, 2023
nataliecarey
nataliecarey reviewed May 23, 2023
View reviewed changes
lib/assets/sass/prototype.scss Outdated

.govuk-prototype-kit-error-page-header {
.govuk-header__container {
border-color: #d4351c;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in govuk-frontend as red (https://github.com/alphagov/govuk-frontend/blob/839adc06ad36aeb1a982d8fd778b39c3c1ee2bae/packages/govuk-frontend/src/govuk/settings/_colours-palette.scss#L18) I think we should be using that if we can in this context.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a look

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now uses the govuk-colour("red") macro

@joelanman
Copy link
Contributor

joelanman commented May 24, 2023 •
edited
Loading

found an unhandled error in a view: 'Error: Unable to call serviceName, which is not a function'

{{ serviceName() }}

results in a blank code block, and this for File:

app/views/index.html) Template render error: (/private/var/folders/27/v2ycqnfd3t507l9c4qwvrx1w0000gp/T/test-prototype/node_modules/govuk-prototype-kit/lib/nunjucks/govuk-prototype-kit/includes/homepage-top.njk (line 1)

@joelanman
Copy link
Contributor

need to do a couple of design/accessibility tweaks, coming soon...

@BenSurgisonGDS BenSurgisonGDS force-pushed the 2019-improve-the-design-of-errors branch from 55ab915 to 7be392b Compare May 25, 2023 09:39
@BenSurgisonGDS
Copy link
Contributor Author

found an unhandled error in a view: 'Error: Unable to call serviceName, which is not a function'

{{ serviceName() }}

results in a blank code block, and this for File:

app/views/index.html) Template render error: (/private/var/folders/27/v2ycqnfd3t507l9c4qwvrx1w0000gp/T/test-prototype/node_modules/govuk-prototype-kit/lib/nunjucks/govuk-prototype-kit/includes/homepage-top.njk (line 1)

Will now report this error best it can

@BenSurgisonGDS BenSurgisonGDS force-pushed the 2019-improve-the-design-of-errors branch from 7be392b to a2d7ea6 Compare May 25, 2023 14:22
nataliecarey
nataliecarey reviewed May 25, 2023
View reviewed changes
CHANGELOG.md Outdated
@@ -6,6 +6,8 @@

- [#2164: Get live reloading working with the error screen](https://github.com/alphagov/govuk-prototype-kit/pull/2164)

- [#2019: Improve the design of the error screen](https://github.com/alphagov/govuk-prototype-kit/pull/2019)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've used the ticket number not the PR number. should be 2183.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix

@nataliecarey
Copy link
Contributor

I want to have a closer look at the regexes but other than that I'm happy with it.

@nataliecarey nataliecarey reopened this May 25, 2023
@BenSurgisonGDS BenSurgisonGDS merged commit 094e8df into main May 25, 2023
@BenSurgisonGDS BenSurgisonGDS deleted the 2019-improve-the-design-of-errors branch May 25, 2023 17:05
@joelanman
Copy link
Contributor

I did say I needed to make accessibility fixes to this. Will make them as a new PR

@nataliecarey
Copy link
Contributor

@joelanman I'm assuming this shouldn't be released until they're done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliecarey nataliecarey nataliecarey approved these changes

@ollie-b-gds ollie-b-gds Awaiting requested review from ollie-b-gds

@HannahJMWood HannahJMWood Awaiting requested review from HannahJMWood

@joelanman joelanman Awaiting requested review from joelanman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the design of errors
3 participants
@BenSurgisonGDS @joelanman @nataliecarey