Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 2235 nunjucks macros validation error #2236

Merged
merged 4 commits into from
Jun 28, 2023
Merged

Issue 2235 nunjucks macros validation error #2236

merged 4 commits into from
Jun 28, 2023

Conversation

HannahJMWood
Copy link
Contributor

@HannahJMWood HannahJMWood commented Jun 28, 2023 •
edited
Loading

  • adding case for nunjucksMacros to the validator

@HannahJMWood HannahJMWood marked this pull request as ready for review June 28, 2023 10:26
BenSurgisonGDS
BenSurgisonGDS approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@BenSurgisonGDS BenSurgisonGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@HannahJMWood HannahJMWood merged commit 0f5db6b into main Jun 28, 2023
@HannahJMWood HannahJMWood deleted the issue_2235-nunjucksMacros-validation-error branch June 28, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenSurgisonGDS BenSurgisonGDS BenSurgisonGDS approved these changes

@nataliecarey nataliecarey Awaiting requested review from nataliecarey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HannahJMWood @BenSurgisonGDS