Upgrading plugins with dependencies #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
BenSurgisonGDS
force-pushed
the
2242-when-installing-or-updating-a-plugin-the-specified-max-version-of-dependency-plugins-should-also-be-installed-or-upgraded
branch
from
25d10c1
to
b59f0c2
Compare
BenSurgisonGDS
force-pushed
the
2242-when-installing-or-updating-a-plugin-the-specified-max-version-of-dependency-plugins-should-also-be-installed-or-upgraded
branch
2 times, most recently
from
0452668
to
39e9461
Compare
|
There's two bugs with uninstalling:
I've recorded a video that shows both these bugs. Plugin.uninstall.bug.mov |
BenSurgisonGDS
force-pushed
the
2242-when-installing-or-updating-a-plugin-the-specified-max-version-of-dependency-plugins-should-also-be-installed-or-upgraded
branch
2 times, most recently
from
e5af97d
to
fd0ab7b
Compare
BenSurgisonGDS
force-pushed
the
2242-when-installing-or-updating-a-plugin-the-specified-max-version-of-dependency-plugins-should-also-be-installed-or-upgraded
branch
from
d59dffc
to
ca8fe9c
Compare
nataliecarey
previously approved these changes
Jul 14, 2023
lib/manage-prototype-handlers.js
Outdated
| }, | ||
| uninstall: { | ||
| title: 'Uninstall', | ||
| para: 'uninstall', | ||
| status: 'uninstalled', | ||
| progressive: 'uninstalling' | ||
| progressive: 'uninstalling', | ||
| other: 'uninstall' |
There was a problem hiding this comment.
Approved, I think there's likely to be a better name than other. if you/we can find a better one before merging that could work or we can just keep an eye out for a better name over time.
nataliecarey
approved these changes
Jul 17, 2023
BenSurgisonGDS
deleted the
2242-when-installing-or-updating-a-plugin-the-specified-max-version-of-dependency-plugins-should-also-be-installed-or-upgraded
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: When updating a plugin relevant dependencies should be installed (the same UX as installing a plugin)
This PR includes: