Fix plugin page failure after updating to 13.10.0 #2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for this please? |
A test has been created to cover this issue. |
BenSurgisonGDS
changed the title
BenSurgisonGDS
force-pushed
the
2248-13100-fails-to-start-when-dependency-missing-from-node_modules
branch
from
842b2e7
to
798bfbd
Compare
lib/manage-prototype-handlers.js
Outdated
| @@ -42,7 +42,7 @@ async function isValidVersion (packageName, version) { | |||
| const { versions = [], localVersion } = await lookupPackageInfo(packageName, version) | |||
| const isVersionValid = [...versions, localVersion].includes(version) | |||
| if (!isVersionValid) { | |||
| console.log('version', version, ' is not valid, valid options are:\n\n', versions) | |||
| console.log('version', version, ' is not valid, valid options are:\n\n', localVersion || versions) | |||
There was a problem hiding this comment.
This log doesn't describe the condition if localVersion is set. I'd suggest using the same array as you check against (const validVersions = [...versions, localVersion])
nataliecarey
previously approved these changes
Jul 13, 2023
nataliecarey
dismissed
their stale review
I forgot I had a comment earlier in the review process
|
Final thing - could you squash the commits please? |
… plugin exists where it is expected.
BenSurgisonGDS
force-pushed
the
2248-13100-fails-to-start-when-dependency-missing-from-node_modules
branch
from
9441c94
to
cbfde67
Compare
nataliecarey
approved these changes
Jul 13, 2023
BenSurgisonGDS
deleted the
2248-13100-fails-to-start-when-dependency-missing-from-node_modules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: 13.10.0 fails to start when dependency missing from node_modules