Renamed upgrade to update #2257
Conversation
nataliecarey
force-pushed
the
2144_use-update-everywhere
branch
from
f5a742d
to
101f602
Compare
nataliecarey
force-pushed
the
2144_use-update-everywhere
branch
2 times, most recently
from
72d6e9b
to
e0e3df9
Compare
cypress/e2e/plugins/plugin-utils.js
Outdated
| cy.get(panelProcessingQuery) | ||
| .should('be.visible') | ||
| .contains(`${capitalize(action === 'upgrade' ? 'Upgrad' : action)}ing ...`) | ||
| if (Cypress.env('SKIP_PLUGIN_ACTION_INTERIM_STEP') !== 'true') { |
There was a problem hiding this comment.
Was there a problem running tests without the ability to skip this section?
There was a problem hiding this comment.
Yeah, I've had problems for a while. On my laptop and my home internet connection the install happens too quickly and it fails because it's in the complete state and it should be in the pending state.
cypress/events/index.js
Outdated
| @@ -61,6 +61,7 @@ module.exports = function setupNodeEvents (on, config) { | |||
| config.env.password = process.env.PASSWORD | |||
| config.env.projectFolder = path.resolve(process.env.KIT_TEST_DIR || process.cwd()) | |||
| config.env.tempFolder = path.join(__dirname, '..', 'temp') | |||
| config.env.SKIP_PLUGIN_ACTION_INTERIM_STEP = process.env.SKIP_PLUGIN_ACTION_INTERIM_STEP | |||
There was a problem hiding this comment.
If we are going to use capitalised snake case for config.env.SKIP_PLUGIN_ACTION_INTERIM_STEP constant, should we not make all the config.env constants follow the same convention?
There was a problem hiding this comment.
Sure, I'll do that.
… steps that fail every time on my machine but pass on CI.
… support updating the kit).
nataliecarey
force-pushed
the
2144_use-update-everywhere
branch
from
e0e3df9
to
066e60c
Compare
That's really odd. I wonder if there is a timing issue or something. Maybe it warrents more investigation in the future, but not in this PR. I'll approve |
It's because I changed the URL, so it does the update on a URL including |
Pre-Release available to test the upgrade flow. I intentionally released one version before catering for the upgrade and one version after so the impact of the change could be tested.
13.10.2-rc.1- the final version of this PR13.10.2-rc.0- an earlier version of this PR which shows how the upgrade breaks (when upgrading to this version)I've also added an environment variable to turn off checking the interim state check for install/upgrade because it fails every time on my machine.