Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin validator allows the user to specify unknown keys #2314

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Plugin validator allows the user to specify unknown keys #2314

merged 1 commit into from
Aug 29, 2023

Conversation

nataliecarey
Copy link
Contributor

@nataliecarey nataliecarey commented Aug 25, 2023 •
edited
Loading

This allows the following syntax when running the validator:

npx govuk-prototype-kit@latest validate-plugin --keysToIgnoreIfUnknown="aProposedFeatures,anotherProposedFeature"

This means that people can add proposed features to their config before the interface is added to the validator as explained in #2312

@nataliecarey nataliecarey merged commit 218ca52 into main Aug 29, 2023
27 checks passed
@nataliecarey nataliecarey deleted the unknown-keys-in-validator branch August 29, 2023 12:54
@nataliecarey nataliecarey mentioned this pull request Aug 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenSurgisonGDS BenSurgisonGDS BenSurgisonGDS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nataliecarey @BenSurgisonGDS