Simplify and improve acceptance tests #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nataliecarey
previously approved these changes
Oct 10, 2023
BenSurgisonGDS
force-pushed
the
Simplify-and-improve-acceptance-tests
branch
from
864ebdf
to
5823d3f
Compare
colinrotherham
previously approved these changes
Oct 11, 2023
BenSurgisonGDS
force-pushed
the
Simplify-and-improve-acceptance-tests
branch
from
5823d3f
to
be59b35
Compare
colinrotherham
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify plugins tests with reusable functions that will meke it is easier to change the functionality (In future adding the plugin details page) without affecting the main acceptance test structure. This also makes it easeir to fix any bugs.