Defer prototype application.js to load after plugin scripts
#2359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 9, 2023
colinrotherham
changed the title
<script type"module">application.js to load after plugin scripts
1 task
BenSurgisonGDS
previously approved these changes
Oct 9, 2023
colinrotherham
force-pushed
the
frontend-v5-deprecated
branch
from
bbf1687
to
d598993
Compare
This enables ES module imports by default:
```
import { Component } from '/plugin-assets/plugin-name/example.js'
```
Since GOV.UK Frontend v5 also uses `<script type="module">`, this change also ensures application.js executes after `window.GOVUKFrontend` is ready
colinrotherham
force-pushed
the
application-script-module
branch
from
d254424
to
28b2756
Compare
|
Moved the CHANGELOG entry into Unreleased |
nataliecarey
previously approved these changes
Oct 10, 2023
colinrotherham
dismissed stale reviews from nataliecarey and BenSurgisonGDS
The base branch was changed.
BenSurgisonGDS
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches
application.jsto<script type"module">to fix:"type": "module"run too late #2353This change defers script load by default and also ensures:
import { Accordion } fromsyntax support in GOV.UK Frontend v5Browser support
This follows GOV.UK Frontend to protect browsers without ES6 modules support from script errors, such as: