Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Browsersync to resolve axios vulnerability #2394

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Conversation

colinrotherham
Copy link
Contributor

@colinrotherham colinrotherham commented Feb 21, 2024

See GitHub Advisory: GHSA-wf5p-g6vw-rhxx

This PR also runs npm update --save to pick up minor/patch versions for other packages

Closes #2383

Browsersync update

Updating from browser-sync@2.29.3browser-sync@3.0.2 is a non-breaking change for this project

The vulnerability only affected Browsersync config tunnel: true which is not used by the Prototype Kit

@joelanman
Copy link
Contributor

thanks this is good and we should do it, but just for clarity, we don't use that option so it's not currently a vulnerability that affects our users I dont think

See GitHub Advisory: GHSA-wf5p-g6vw-rhxx

Updating to `browser-sync@3` is a non-breaking change because this project does not use `tunnel: true`
Copy link
Contributor

@domoscargin domoscargin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the smell of freshly updated dependencies...

Base automatically changed from frontend-5.2.0 to main February 22, 2024 11:33
@colinrotherham colinrotherham merged commit dcf4429 into main Feb 22, 2024
30 checks passed
@colinrotherham colinrotherham deleted the package-updates branch February 22, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulnerability in axios
3 participants