Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop accidentally cleaning up non-expired sessions #2399

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Stop accidentally cleaning up non-expired sessions #2399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/session-file-store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,11 @@ class FileStore extends Store {
}

async set (sessionId, session, callback = noop) {
let storedSessionId
try {
// Delete any expired sessions before creating a new session
const storedSessionFiles = await fse.readdir(this.path)
await Promise.all(storedSessionFiles.map(async sessionFile => {
storedSessionId = sessionFile.replace('.json', '')
const storedSessionId = sessionFile.replace('.json', '')
try {
const storedSession = await fse.readJson(path.join(this.path, sessionFile))
if (isExpired(storedSession)) {
Expand Down
Loading