Add kit version to footer #476
Conversation
|
@mikeshawdev thanks for this! Would you be able to amend the description so it's clearer what this changes and why you think it's good to do? it would also be great to include a screenshot of how it appears on pages. |
|
@mikeshawdev sorry for the delay, thanks for this work, it's definitely something that would helpful. Do you have time to update or respond to the code comments? |
|
@joelanman no worries, I've updated the description of the PR in response to @edwardhorsford's comments |
|
@mikeshawdev oh geez my mistake, I made a review but didn't 'submit' it so you can't see it! Sorry about that, submitting now |
app/views/layout.html
Outdated
| @@ -36,14 +36,21 @@ | |||
| with-proposition | |||
| {% endblock %} | |||
|
|
|||
| {% block footer_top %} | |||
| {# <p>Prototype kit version {{ releaseVersion }}</p> #} | |||
| {% endblock %} | |||
There was a problem hiding this comment.
Thanks for this work! Is this section supposed to be here? It looks like it's just got a commented-out line in it
app/views/layout.html
Outdated
| <ul> | ||
| <ul> | ||
| <li> | ||
| Prototype kit {{ releaseVersion }} |
There was a problem hiding this comment.
Could this be GOV.UK Prototype Kit - makes it consistent with how we refer to it elsewhere
Signed-off-by: Mike Shaw <mike.shaw@dwp.gsi.gov.uk>
|
@joelanman updated the code based on your comments 👍 |
|
Thanks! Can you add a line to CHANGELOG? |
Signed-off-by: Mike Shaw <mike.shaw@dwp.gsi.gov.uk>
|
Done, and done! |
|
Hi @mikeshawdev really sorry, just had a quick discussion on the team and can we go back to it not being a link? Not sure of the user need, and not 100% sure that the generated link will always work (the tag in GitHub would have to be exactly the same as the version in package.json, which it ought to be, but they could possibly go out of sync) |
|
@joelanman great minds think alike! I've just opened this issue on As it stands, you cannot have plain text in that list so I've had to use a link for now |
|
Sorry, telling you to do something that can't be done! In the meantime, I think maybe change the link to just go to the Prototype Kit site: https://govuk-prototype-kit.herokuapp.com/ |
Signed-off-by: Mike Shaw <mike.shaw@dwp.gsi.gov.uk>
|
Amend made 👍 |
|
great! thanks |
This change adds a line to the footer, which states the current version of the prototyping kit being used. Screenshot below.
This makes it clear to users which version of the kit is being used, as they don't need to check the console or source code for this information when using a prototype.
Resolves #455.