Use path to gulp executable for spawn #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mikeshawdev, Sorry for the long time before getting a response, this work looks good. Would you be willing to update your branch so we can merge this? It would require a CHANGELOG entry for this bug fix. If not I can clean this up on your behalf and get it in. Nick |
|
@NickColley all updated 👍 |
NickColley
approved these changes
Aug 21, 2018
|
@mikeshawdev @NickColley You could try using It'll find the gulp binary automatically. |
added 2 commits
September 10, 2018 10:53
Previously the spawn command just took `gulp` as an argument, which worked when running the app via `npm start`. However, running `node start` would fail because it couldn't find `gulp`. It would look globally, whereas `npm start` would look locally. Referencing the path within `node_modules` directly means both commands can be used to start and run the app.
Signed-off-by: Mike Shaw <mike.shaw@dwp.gsi.gov.uk>
36degrees
approved these changes
Sep 10, 2018
|
Thanks @mikeshawdev :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the spawn command just took
gulpas an argument, which worked when running the app vianpm start. However, runningnode startwould fail because it couldn't findgulp. It would look globally, whereasnpm startwould look locally. Referencing the path withinnode_modulesdirectly means both commands can be used to start and run the app.Resolves #393.