Improve error handling #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelanman
commented
Jul 25, 2018
lib/utils.js
Outdated
| // be found as test.html, but then found as test/index.html. If neither is | ||
| // found, we log a single error at the end (in server.js) | ||
| if (!err.message.startsWith('template not found')) { | ||
| console.error(err.message) |
There was a problem hiding this comment.
we could try and pass this to next - but we'd need to send both this error and the next one (line 207)
joelanman
force-pushed
the
improve-error-handling
branch
3 times, most recently
from
e5cbb68
to
f6bfef0
Compare
joelanman
changed the title
- Use 'next' and middleware to handle errors, this is the documented way to handle errors in Express - Use console.error to output errors when rendering templates - these were previously hidden - Remove custom route for index.html, handle it with matchRoutes for consistency
joelanman
force-pushed
the
improve-error-handling
branch
from
f6bfef0
to
68c48cf
Compare
kr8n3r
approved these changes
Jul 27, 2018
This was referenced Jul 27, 2018
Closed
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work has been pulled out of #553 as useful in its own right, and helps to prepare for that