Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename and reorganise template pages to be easier to use #578

Merged
merged 2 commits into from
Aug 14, 2018
Merged

Rename and reorganise template pages to be easier to use #578

merged 2 commits into from
Aug 14, 2018

Conversation

joelanman
Copy link
Contributor

  • moves all templates into their own folder called templates
  • renames templates to just be the name of the page - remove 'template' and 'page'

@joelanman
Copy link
Contributor Author

Is 'content' the best name for the page which is a step in your service which is just content, not a question? (It is the same as Question template, but no form)

NickColley
NickColley approved these changes Aug 14, 2018
View reviewed changes
Copy link
Contributor

@NickColley NickColley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@joelanman
Copy link
Contributor Author

Resolves #488

@dashouse
Copy link

Probably good to have a chat with Amy regarding Check answers / Check your answers

@joelanman
Copy link
Contributor Author

Have agreed to change to check-answers with @amyhupe however will do this as a separate PR as it will require wider changes (for example to the SCSS)

@joelanman joelanman merged commit 3ed4a3c into master Aug 14, 2018
@joelanman joelanman deleted the improve-templates branch August 14, 2018 14:26
@joelanman joelanman mentioned this pull request Aug 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickColley NickColley NickColley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joelanman @dashouse @NickColley