Load variables from .env before requiring routes #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code in `route.js` may be looking for environment variables. If the environment variables aren’t loaded beforehand this will cause an exception. I suspect this worked fine before bbe15e8#diff-78c12f5adc1848d13b1c6f07055d996e, which reordered the first lines in `server.js`. This commit moves the loading of environment variables to before the requiring of any `routes.js` files.
joelanman
changed the title
kr8n3r
approved these changes
Aug 15, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code in
route.jsmay be looking for environment variables. If the environment variables aren’t loaded beforehand this will cause an exception.I suspect this worked fine before bbe15e8#diff-78c12f5adc1848d13b1c6f07055d996e, which reordered the first lines in
server.js.This commit moves the loading of environment variables to before the requiring of any
routes.jsfiles.