Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm install reminder on crash #598

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

colinrotherham
Copy link
Contributor

@colinrotherham colinrotherham commented Sep 10, 2018

Not everyone remembers (or knows about) the npm install guidance when updating here:
https://govuk-prototype-kit.herokuapp.com/docs/updating-the-kit

I've added a crash listener to Nodemon to output a little reminder:

crash-warning

Thought it might help 🙂

@colinrotherham
Copy link
Contributor Author

As discussed @NickColley

Copy link

@kr8n3r kr8n3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colinrotherham thanks for this 👍
need a second approval from the team though

Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @colinrotherham 👍

@36degrees 36degrees merged commit 29f8ac5 into alphagov:master Oct 30, 2018
@kr8n3r kr8n3r added this to the [NEXT] milestone Oct 30, 2018
@kr8n3r kr8n3r mentioned this pull request Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants