Remove gulp-util #664
Merged
Remove gulp-util #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-664
|
Do we need to colour this message? Not sure we colour others |
|
I think its trying to ensure all nodemon logs are coloured in the similar way to the the ones we already have:
|
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-664
joelanman
approved these changes
Jan 2, 2019
gulp-util is deprecated - replace it, following the guidelines at https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5 We only used this for logging and colouring our log outputs.
aliuk2012
force-pushed
the
remove-gulp-util
branch
from
11a48ae
to
63a765e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the warning mentioned in issue #660 by replacing gulp-util with the two individual packages (ansi-color and fancy-logs) as recommended here.
Another great thing about removing gulp-utils is that it was pulling in 18 other dependencies. Ansi-color required no other dependencies and fancy-logs needs only 4 small dependencies.