Add acorn to dependency to fix npm Warning #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We dont really need it but its needed for Standard and gulp-sourcemaps. Heroku removes dev dependency by default.
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-667
|
can we add to changelog? |
aliuk2012
changed the title
joelanman
approved these changes
Jan 4, 2019
Merged
lfdebrux
added a commit
that referenced
this pull request
Dec 14, 2022
In PR #667 we added `acorn` as a direct dependency to fix complaints from npm about peer dependencies, due to a bug in npm [[1]]. That bug now appears to have been fixed; removing `acorn` from our `package.json` does not result in any peer dependency warnings. Also, as we now ensure that users do not install dev dependencies, we can be confident that they will not need `acorn`, as it is only required by dev dependencies. [1]: #666
lfdebrux
added a commit
that referenced
this pull request
Dec 14, 2022
In PR #667 we added `acorn` as a direct dependency to fix complaints from npm about peer dependencies, due to a bug in npm [[1]]. That bug now appears to have been fixed; removing `acorn` from our `package.json` does not result in any peer dependency warnings. Also, as we now ensure that users do not install dev dependencies, we can be confident that they will not need `acorn`, as it is only required by dev dependencies. [1]: #666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We dont really need it but its needed for Standard and gulp-sourcemaps.
#666 deploy failed because Heroku removes dev dependency by default.