Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ‘check answers’ pattern with updated code #672

Merged
merged 3 commits into from
Jan 16, 2019
Merged

Replace ‘check answers’ pattern with updated code #672

merged 3 commits into from
Jan 16, 2019

Conversation

dashouse
Copy link

This PR

  • Removes the check-your-answers stylesheet and reference to it in the application.scss file
  • Adds a new version of Check answers using the 'summary list' component and desktop specific grid classes introduced in GOV.UK Frontend 2.5.0

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-672 January 11, 2019 15:24 Inactive
@joelanman joelanman self-requested a review January 11, 2019 18:29
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-672 January 14, 2019 08:39 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-672 January 14, 2019 08:46 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-672 January 14, 2019 09:29 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-672 January 14, 2019 09:33 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-672 January 14, 2019 09:34 Inactive
@dashouse dashouse changed the title Replace ‘check answers’ pattern with updated code DNM - Replace ‘check answers’ pattern with updated code Jan 14, 2019
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-672 January 14, 2019 14:53 Inactive
@dashouse dashouse changed the title DNM - Replace ‘check answers’ pattern with updated code Replace ‘check answers’ pattern with updated code Jan 15, 2019
@dashouse
Copy link
Author

Final changes made to the Design System version of this - alphagov/govuk-design-system#692 and applied to this PR.

Happy to do a final review?

joelanman
joelanman approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@joelanman joelanman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks @dashouse !

@joelanman joelanman temporarily deployed to govuk-prototype-kit-pr-672 January 16, 2019 11:58 Inactive
@joelanman joelanman merged commit d89c86a into master Jan 16, 2019
@joelanman joelanman deleted the update-check-answers branch January 16, 2019 15:31
@joelanman joelanman mentioned this pull request Jan 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanman joelanman joelanman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dashouse @joelanman @govuk-design-system-ci