Add guidance for CSS, JavaScript and images #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@soupdragon99 I made a couple of small changes - you can see the page in situ if you click 'show environments' above. |
NickColley
reviewed
Feb 5, 2019
| Link to it like this: | ||
|
|
||
| ``` | ||
| <a href="/public/downloads/report.pdf">Download the report</a> |
There was a problem hiding this comment.
Super non-blocking but maybe the download attribute would be useful here: https://caniuse.com/#feat=download
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #616
Adds guidance for how to add your own CSS, JavaScript and images.
In particular it tells you not to use
/publicfolder directly, and changes made there will be lost. This happens fairly regularly to users.