Update docs and package.json to Node 10 LTS #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickColley
approved these changes
Feb 6, 2019
There was a problem hiding this comment.
It's worth noting that the team runs 8.9.4 day to day, so ideally we'd update our other repositories to mirror this.
There's also a risk that we introduce changes that break users on 6.x, 8.x etc, but that's always been an issue given we only test in one Node.js version.
|
Does this need Changelog? What kind of change is it? |
This was referenced Feb 6, 2019
|
@NickColley good point about previous versions, I'm sure we used to test in current and previous LTS, maybe we should bring that back |
Been looking at that at the same time as the Windows tests 🙂 |
|
Yeh I think we should test this on Windows before merging, to be sure |
joelanman
force-pushed
the
use-node-10
branch
from
266a7e8
to
3803658
Compare
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tell people to get LTS, which has been 10 for a few months now. This updates the docs and package.json from 8 to 10.
Closes #661