Turn off npm default auditing #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-712
zuzak
reviewed
Mar 18, 2019
.npmrc
Outdated
| @@ -1 +1,2 @@ | |||
| package-lock=false | |||
| audit=false | |||
There was a problem hiding this comment.
At the risk of being (very) pernickety, there's no new line at the end of this file, which is inconsistent and might cause problems with tooling down the line
There was a problem hiding this comment.
Will sort it, thanks :)
We have decide to avoid showing users of the prototype kit audit messages. This is because a lot of the low level issues are not easy to fix, and will cause unnecessary worry. We will prioritise the security alerts we recieve from GitHub's monitoring. See #699 for the full discussion.
NickColley
force-pushed
the
hide-npm-audit-warnings
branch
from
0461086
to
b90ae84
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have decide to avoid showing users of the prototype kit audit messages.
This is because a lot of the low level issues are not easy to fix, and will cause unnecessary worry.
We will prioritise the security alerts we recieve from GitHub's monitoring.
See #699 for the full discussion.
Resolves #699