Fix sass error #763
Merged
Fix sass error #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test currently fails because there is a compilation error in the unbranded stylesheet.
In d901c7f we removed an import of govuk-frontend/settings/all because it caused issues for users overriding settings that relied on each other. However, this broke the unbranded stylesheet as it refers to `$govuk-body-background-colour` which was then undefined. Importing only the colour palette and applied colour settings solves this problem. We also document the fact that if a user (for whatever reason) wants to enable compatibility mode or use the legacy palette then they should do that before the import statements.
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-763
|
#295 seems relevant here as we (I!) missed this error during development. |
Definitely we since I missed this too 🤦♂ |
NickColley
approved these changes
Jun 6, 2019
aliuk2012
approved these changes
Jun 6, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Prototype Kit is currently throwing a Sass error when trying to compile the unbranded stylesheet.
In d901c7f we removed an import of govuk-frontend/settings/all because it caused issues for users overriding settings that relied on each other.
However, this broke the unbranded stylesheet as it refers to
$govuk-body-background-colourwhich was then undefined.Importing only the colour palette and applied colour settings solves this problem. We also document the fact that if a user (for whatever reason) wants to enable compatibility mode or use the legacy palette then they should do that before the import statements.
This also adds a test which compiles all Sass files in
assets/sass, surfacing any compilation errors, which would have caught this.