Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update task list focus state #770

Merged
merged 2 commits into from
Jul 23, 2019
Merged

Update task list focus state #770

merged 2 commits into from
Jul 23, 2019

Conversation

36degrees
Copy link
Contributor

@36degrees 36degrees commented Jul 22, 2019

Before

Desktop

localhost_3001_docs_templates_task-list(Desktop) (2)

Mobile

localhost_3001_docs_templates_task-list(iPhone X) (2)

After

Desktop

localhost_3001_docs_templates_task-list(Desktop) (1)

Mobile

localhost_3001_docs_templates_task-list(iPhone 6_7_8 Plus)

Fixes #756

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-770 July 22, 2019 09:31 Inactive
Copy link
Contributor

@NickColley NickColley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tony the tiger saying "it's great"

@NickColley NickColley added this to the v9.0.0 milestone Jul 22, 2019
@NickColley
Copy link
Contributor

@36degrees needs a CHANGELOG entry...

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-770 July 22, 2019 13:45 Inactive
@36degrees
Copy link
Contributor Author

@NickColley added a changelog entry – we can review it properly when we pick up #772?

Copy link
Contributor

@NickColley NickColley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, will leave for @m-green to have a peak.

Edit: sure lets merge and do a full review later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants