Update Kit to use latest active LTS Node.js version 12.x #840
Conversation
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-840
NickColley
force-pushed
the
update-kit-to-focus-on-latest-lts-release-12
branch
from
a9d5643
to
9ec2093
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-840
NickColley
force-pushed
the
update-kit-to-focus-on-latest-lts-release-12
branch
from
9ec2093
to
4e7605e
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-840
NickColley
force-pushed
the
update-kit-to-focus-on-latest-lts-release-12
branch
from
4e7605e
to
21f9210
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-840
|
I've put blocked on this as I believe that we should get everything to 12 at the same time if possible to avoid issues when developing between these projects but let's discuss the issues in the GOV.UK Design System repository and decide what to do. |
|
Spoke to @36degrees, we're going to run different versions for now, see full statement here: alphagov/govuk-design-system#1091 (comment) |
.travis.yml
Outdated
| - "10.15.1" | ||
| - "8" | ||
| - "10.17.0" # lts/dubnium | ||
| - "12.13.1" # lts/erbium |
There was a problem hiding this comment.
can we use "10" and "12" so that we build against the latest minor/patch releases?
There was a problem hiding this comment.
I think it's better to have it pinned so that our build is stable, otherwise it'll update over time and could start failing?
There was a problem hiding this comment.
if it fails that might be good to know - it could be failing for users downloading and using that latest version of Node
There was a problem hiding this comment.
I'm trying to keep our development environments consistent with CI since we don't often work on Kit features, I'd prefer @36degrees make the decision here.
There was a problem hiding this comment.
The other repositories are not run by our users so I think let's make an exception here and take the risk of it blowing up now and then.
There was a problem hiding this comment.
I think it's better to know in the (hopefully unlikely) case that a new minor version causes issues with the kit.
package.json
Outdated
| @@ -4,7 +4,7 @@ | |||
| "version": "9.4.0", | |||
| "private": true, | |||
| "engines": { | |||
| "node": "^10.0.0" | |||
| "node": "12.13.1" | |||
There was a problem hiding this comment.
| "node": "12.13.1" | |
| "node": "^12.0.0" |
?
|
Just to note I don't think this closes #828 on its own - the documentation still needs updating to not tell people to get Node 10 (currently I think the 'closes 828' comment might automatically close 828 if this is merged, maybe?) |
Since the Carbon LTS release is end of life december I have dropped this to focus on only the LTS versions that will be maintained.
NickColley
changed the title
NickColley
force-pushed
the
update-kit-to-focus-on-latest-lts-release-12
branch
from
21f9210
to
adf2b54
Compare
@joelanman this PR updates the documentation that I'm aware of that mentions any specific version of node – is there something we've missed? |
|
@36degrees the documentation changes were made after my comment, looks all good now! |
Since the Node.js website only shows 12 it makes sense for us to support the version new users will be installing.
Carbon LTS release (8.x) is end of life December I have dropped this to focus on only the LTS versions that will be maintained, this will cut down on build times, but the kit should still work just will not be tested by CI.
I have also opened pull requests to the
govuk-design-systemandgovuk-frontendrepositories to keep everything aligned.Closes #828