Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update step by step patterns to latest #847

Merged
merged 4 commits into from
Jan 16, 2020

Conversation

NickColley
Copy link
Contributor

@NickColley NickColley commented Jan 9, 2020

Update the step by step pattern by copying the original scss files and changing the gem-c- namespace to app-.

Split the single step-by-step-navigation file into three that mirror the three in govuk_publishing_components for easier maintence in the future.

For the JavaScript, copy the govuk_publishing_component JavaScript, replace gem-c- namespace with app-, rename module to AppStepNav from Gemstepnav

I've also made the analytics function do nothing as it's not relevant for a prototype.

Finally do a small tweak to the related items divider width.

Comparison between the Kit and live examples

Step by step pattern

Start page with step by step pattern

Update the step by step pattern by copying the original scss files and changing the `gem-c-` namespace to `app-`.

Split the single step-by-step-navigation file into three that mirror the three in govuk_publishing_components for easier maintence in the future.
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-847 January 9, 2020 16:03 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-847 January 9, 2020 16:30 Inactive
Copy the govuk_publishing_component JavaScript, replace `gem-c-` namespace with `app-`, rename module to `AppStepNav` from `Gemstepnav`

I've also made the analytics function do nothing as it's not relevant for a prototype.
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-847 January 9, 2020 16:36 Inactive
@NickColley NickColley marked this pull request as ready for review January 9, 2020 16:37
Copy link
Member

@hannalaakso hannalaakso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Reviewed by comparing what's in https://github.com/alphagov/govuk_publishing_components/tree/master/app/assets and checked that everything still works.

This is a change to /app so users with existing prototypes won't get it unless they manually make the changes. It doesn't feel like a big/important enough change to prompt all users to update their existing versions of kit, given the overhead of updating all the relevant files? What do you think @NickColley?

In the long term these files probably shouldn't live in app (out of scope for this PR).

@NickColley
Copy link
Contributor Author

@hannalaakso yeah I agree I think the changes to the pattern are small enough that it's not worth adding instructions to manually update but we can reconsider this based on user feedback.

@NickColley NickColley merged commit 1af0ddc into master Jan 16, 2020
@NickColley NickColley deleted the update-step-by-step-pattern branch January 16, 2020 13:22
@hannalaakso hannalaakso mentioned this pull request Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants