Update various dependencies and fix linting offences #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-885
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-885
Updating this resolves 2 vulnerabilities in marked as reported by npm audit: https://npmjs.com/advisories/812 https://npmjs.com/advisories/1076
Acorn is only installed to fix an npm warning, as a dependency of standard and gulp-sourcemap. The changelog for 7.0.0 suggests that this shouldn't break anything.
ansi-colors is only used in the nodemon task, and this still works fine.
del 4.0.0 drops support for node < 6.0. del 5.0.0 drops support for node < 8.0, removes the ability to pass in paths with backwards slashes, and updates globby. None of this affects us.
dotenv 7.0.0 removes a 'load' alias for the config function, which we're not using. dotenv 8.0.0 drops support for node v6.0.
This is a minor version bump, which wasn't done in 09f5440 because it was previously pinned to a specific version.
Seeing this when running tests: > Jest did not exit one second after the test run has completed. > > This usually means that there are asynchronous operations that weren't stopped in your tests. Consider running Jest with `--detectOpenHandles` to troubleshoot this issue. However I'm getting the same output when running tests on master.
The tests still pass!
This is used when creating unique client IDs for usage analytics. I've removed the config and re-generated the client ID and it worked fine.
36degrees
force-pushed
the
update-dependencies
branch
from
6587892
to
87f152d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggest reviewing commit-by-commit.