Add support for Node v14 #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v4.12.0 does not support Node v14: > Error: Node Sass does not yet support your current environment: OS X 64-bit with Unsupported runtime (83) > For more information on which environments are supported please see: > https://github.com/sass/node-sass/releases/tag/v4.13.1 > at module.exports (/Users/oliverbyford/Code/govuk-prototype-kit/node_modules/node-sass/lib/binding.js:13:13) > at Object.<anonymous> (/Users/oliverbyford/Code/govuk-prototype-kit/node_modules/node-sass/lib/index.js:14:35) > at Module._compile (internal/modules/cjs/loader.js:1200:30) > at Object.Module._extensions..js (internal/modules/cjs/loader.js:1220:10) > at Module.load (internal/modules/cjs/loader.js:1049:32) > at Function.Module._load (internal/modules/cjs/loader.js:937:14) > at Module.require (internal/modules/cjs/loader.js:1089:19) > at require (internal/modules/cjs/helpers.js:73:18) > at Object.<anonymous> (/Users/oliverbyford/Code/govuk-prototype-kit/node_modules/gulp-sass/index.js:162:21) > at Module._compile (internal/modules/cjs/loader.js:1200:30) > gulp exited with code 1
Prompt's dependency winston is causing a warning in the console: > (node:15613) Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency This has been raised as an issue on prompt's GitHub repo [1] but given the last release of prompt was 4 years ago, I think it makes sense to move away to an alternative that's actively maintained. [1]: flatiron/prompt#199
This fixes a type error that's being thrown by Object.writeFileSync in Node v14: > UnhandledPromiseRejectionWarning: TypeError [ERR_INVALID_ARG_TYPE]: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received type number (3001) > at Object.writeFileSync (fs.js:1380:5) > at /Users/oliverbyford/Code/govuk-prototype-kit/lib/utils.js:99:14 > at processTicksAndRejections (internal/process/task_queues.js:97:5)
Prompt's dependency winston is causing a warning in the console: > (node:15613) Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency This has been raised as an issue on prompt's GitHub repo [1] but given the last release of prompt was 4 years ago, I think it makes sense to move away to an alternative that's actively maintained. [1]: flatiron/prompt#199
> DeprecationWarning: Deep requiring like `const uuidv4 = require('uuid/v4');` is deprecated as of uuid@7.x. Please require the top-level module when using the Node.js CommonJS module or use ECMAScript Modules when bundling for the browser. See https://github.com/uuidjs/uuid#deep-requires-now-deprecated for more information.
Node v14 will become the active LTS release in October 2020, at which point we should recommend that users start installing it. (v12 will remain supported under LTS until 30 April 2022) Until then, some users may only be able to install v14 as the current/latest version – for example, if a department provides Node through a managed software centre – so we should make sure it works with it.
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-901
Both places that used prompt have been updated to use inquirer instead, so prompt can now be removed.
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-901
hannalaakso
approved these changes
May 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details.
Closes #898