Update Task List template #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-907
alex-ju
approved these changes
May 28, 2020
36degrees
force-pushed
the
update-task-list
branch
from
6942972
to
6d2bff0
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-907
We're updating the task list pattern in the Design System to make it clearer which tasks still need to be done [1]. This updates the template in the Prototype Kit so that it matches the examples used in the Design System. [1]: alphagov/govuk-design-system#1250
36degrees
force-pushed
the
update-task-list
branch
from
6d2bff0
to
86c90ec
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-907
It's unclear how these would be helpful to users, so remove them until we see evidence that they're required and that they actually enhance the accessibility of the task list.
m-green
reviewed
Jun 10, 2020
CHANGELOG.md
Outdated
| .app-task-list__task-completed { | ||
| ``` | ||
|
|
||
| [#907 Update Task List template](https://github.com/alphagov/govuk-prototype-kit/pull/907) |
There was a problem hiding this comment.
Suggested change
| [#907 Update Task List template](https://github.com/alphagov/govuk-prototype-kit/pull/907) | |
| This was added in pull request [#907: Update Task List template](https://github.com/alphagov/govuk-prototype-kit/pull/907) |
Just a tweak to match the new style we used in FE 3.7.0.
CHANGELOG.md
Outdated
|
|
||
| The task list pattern has been updated with changes to the [task list pattern in the Design System](https://design-system.service.gov.uk/patterns/task-list-pages/). | ||
|
|
||
| If you're upgrading from an older version, in `app/assets/sass/patterns/task-list.scss` add the line `.app-task-list__tag,` before `.app-task-list__task-completed {`: |
There was a problem hiding this comment.
Suggested change
| If you're upgrading from an older version, in `app/assets/sass/patterns/task-list.scss` add the line `.app-task-list__tag,` before `.app-task-list__task-completed {`: | |
| If you're updating from an older version, in your `app/assets/sass/patterns/task-list.scss` file add the line `.app-task-list__tag,` before `.app-task-list__task-completed {`: |
Slight tweak for clarity / consistency.
CHANGELOG.md
Outdated
|
|
||
| ### Updated task list template | ||
|
|
||
| The task list pattern has been updated with changes to the [task list pattern in the Design System](https://design-system.service.gov.uk/patterns/task-list-pages/). |
There was a problem hiding this comment.
I think it's worth explaining the change a bit here. Something like: "The [task list pattern has been updated in the Design System] to make it clearer which tasks users still need to do."
CHANGELOG.md
Outdated
| @@ -1,5 +1,20 @@ | |||
| # Unreleased | |||
|
|
|||
| ## Fixes | |||
There was a problem hiding this comment.
Would this be more of a new feature? With a heading of "The task list pattern is now clearer about incomplete tasks"? Not sure - happy either way.
hannalaakso
approved these changes
Jun 10, 2020
36degrees
force-pushed
the
update-task-list
branch
from
4ab2aaf
to
e2a2b22
Compare
36degrees
force-pushed
the
update-task-list
branch
from
e2a2b22
to
9618dc5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're updating the task list pattern in the Design System to make it clearer which tasks still need to be done.
This updates the template in the Prototype Kit so that it matches the examples used in the Design System.
Preview the updated template.
Closes #904