Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update marked to fix security issue #938

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Update marked to fix security issue #938

merged 1 commit into from
Oct 8, 2020

Conversation

joelanman
Copy link
Contributor

Fixes #933

36degrees
36degrees approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marked 1.2.0 has been released since this PR was raised originally, so I've updated it to use that.

The release notes for the breaking 1.0.0 release don't flag anything I believe would affect our users, and I've tested locally and it seems to work fine.

@joelanman joelanman merged commit 79a7e30 into master Oct 8, 2020
@joelanman joelanman deleted the update-marked branch October 8, 2020 09:10
@hannalaakso hannalaakso added this to the v9.11.0 milestone Nov 11, 2020
TechPunk316
TechPunk316 reviewed Nov 19, 2020
View reviewed changes
Copy link

@TechPunk316 TechPunk316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FBM

@vanitabarrett vanitabarrett mentioned this pull request Nov 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TechPunk316 TechPunk316 TechPunk316 left review comments

@36degrees 36degrees 36degrees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v9.11.0
Development

Successfully merging this pull request may close these issues.

Snyk / npm install / audit alerts
6 participants
@joelanman @36degrees @TechPunk316 @hannalaakso @govuk-design-system-ci @kellylee-gds