-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sass errors clearer to the user #990
Conversation
b899f78
to
04f520b
Compare
04f520b
to
5e2d2fc
Compare
5e2d2fc
to
ac8ae57
Compare
the output now looks like this:
|
Thanks for looking into this @joelanman ! This approach makes the most sense to me. It gives the user a clue that something has gone wrong with the sass even if they don't spot the error message first. It does feel a bit hacky that we have to do this in the first place, but I can't think of an alternative... I'd be interested in seeing what @36degrees and @hannalaakso think. |
Seems okay to me too. And we're limiting the impact of the changes to a specific action (when Sass compilation throws an error). Do we know if anyone from the community has had a chance to review this? It feels like the sort of thing that it would be good to run past a user to see if it makes sense to them. |
@hannalaakso great point, have now tested with 3 users and the fact the site looks broken when a sass error occurs is very clear to all. 1 participant didn't realise there was an error in the terminal, but I think we can look at adding guidance in the tutorial to check the terminal for errors in general. |
ac8ae57
to
f54027b
Compare
to fix issue #295