Skip to content

Commit

Permalink
Update icon references
Browse files Browse the repository at this point in the history
- Include icons references in the new manifest.json file in the head section instead
- Remove request to the manifest.json and the asset path for this file
  • Loading branch information
MartinJJones committed Jun 17, 2024
1 parent af5c733 commit b8ae101
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion app/assets/config/govuk_publishing_components_manifest.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
//= link_tree ../images
//= link_tree ../../../node_modules/govuk-frontend/dist/govuk/assets/images
//= link_tree ../../../node_modules/govuk-frontend/dist/govuk/assets/fonts
//= link_tree ../../../node_modules/govuk-frontend/dist/govuk/assets

// Create asset files of each of the files in these directory
//= link_directory ../javascripts/component_guide
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,9 @@
<link rel="icon" sizes="48x48" href="<%= asset_path 'favicon.ico' %>">
<link rel="icon" sizes="any" href="<%= asset_path 'favicon.svg' %>" type="image/svg+xml">
<link rel="mask-icon" href="<%= asset_path 'govuk-icon-mask.svg' %>" color="#0b0c0c">
<link rel="icon" href="<%= asset_path 'govuk-icon-512.png' %>">
<link rel="icon" href="<%= asset_path 'govuk-icon-192.png' %>">
<link rel="apple-touch-icon" href="<%= asset_path 'govuk-icon-180.png' %>">
<link rel="manifest" href="<%= asset_path "manifest.json" %>">
<meta name="theme-color" content="#0b0c0c" />
<meta name="viewport" content="width=device-width, initial-scale=1">
Expand Down
1 change: 0 additions & 1 deletion config/initializers/assets.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
Rails.application.config.assets.paths += %W[
#{__dir__}/../../node_modules/govuk-frontend/dist/govuk/assets/images
#{__dir__}/../../node_modules/govuk-frontend/dist/govuk/assets/fonts
#{__dir__}/../../node_modules/govuk-frontend/dist/govuk/assets
#{__dir__}/../../node_modules/govuk-frontend/dist
#{__dir__}/../../node_modules/
]
Expand Down

0 comments on commit b8ae101

Please sign in to comment.