Skip to content

Commit

Permalink
Remove unnecessary select height adjustment
Browse files Browse the repository at this point in the history
This was introduced in August 2019 [1] to mitigate an issue in GOV.UK Frontend where the height of a select component was set in pixels, which meant it did not scale if users changed the text size in their browser [2].

That issue was fixed in GOV.UK Frontend [3] and released as part of v3.3.0 [4] in October 2019. Since then the height of a select component has been set in rem (as long as compatibility mode is not enabled) which means this adjustment can be removed.

[1]: #1018
[2]: alphagov/govuk-frontend#1519
[3]: alphagov/govuk-frontend#1574
[4]: https://github.com/alphagov/govuk-frontend/releases/tag/v3.3.0#:~:text=Pull%20request%20%231574%3A%20Make%20form%20elements%20scale%20correctly%20when%20text%20resized%20by%20user.
  • Loading branch information
36degrees authored Jun 1, 2023
1 parent 6d05b6b commit b94d55d
Showing 1 changed file with 0 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,3 @@
.gem-c-select__select--full-width {
width: 100%;
}

// Solution to text inside selects becoming unreadable if font size in
// the browser is increased. This is currently a problem in govuk-frontend
.gem-c-select {
.govuk-select {
height: 2.14em;
}
}

0 comments on commit b94d55d

Please sign in to comment.