-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate input aria documentation and tests #1062
Conversation
Could we avoid doing this by updating the pattern on that page to match the current recommendations for errors? I don't believe we promote using |
I've made an example of this: https://govuk-frontend-local-council.glitch.me/ |
@36degrees did an investigation here: alphagov/govuk-frontend#1168 |
039aa74
to
f16fdc4
Compare
@NickColley you're absolutely right. I was so busy trying to implement this feature I didn't stop to consider if we actually needed it or not. I've reworked this PR to not have this addition but still have the consolidation of the aria examples and tests, which I think is worth keeping. Thanks! |
f16fdc4
to
933ee68
Compare
933ee68
to
c82f412
Compare
This PR has been updated and no longer does what it originally did.
What
Consolidate the aria attribute documentation for the input component.
A possible future change (for more than just this component) could be to pass any required aria attributes to components rather than having to add new options for each new use case, as below.
Visual Changes
No visual changes.
View Changes
https://govuk-publishing-compo-pr-1062.herokuapp.com/component-guide/input