Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder the navigation lists vertically #2303

Merged
merged 3 commits into from
Sep 15, 2021
Merged

Reorder the navigation lists vertically #2303

merged 3 commits into from
Sep 15, 2021

Commits on Sep 14, 2021

  1. Reorder the navigation lists vertically

    Lists are easier to scan when each column is alphabetically sorted vertically.
    This is possible to do automagically with CSS columns, but Chrome doesn't like
    CSS columns when links are using `text-decoration-thickness` [1][2] - so another
    solution was needed.
    
    CSS Grid Layout has support going back to IE 10[3] and allows for vertical
    columns as long as the number of items in the columns are known - so when the
    navigation is updated the CSS controlling the grid needs to be updated.
    
    [1]: alphagov/govuk-frontend#2204
    [2]: https://bugs.chromium.org/p/chromium/issues/detail?id=1190987
    [3]: https://caniuse.com/css-grid
    injms committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    94a2b51 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2021

  1. Add mixin for more robust navigation updates

    The mixin outputs the styles needed for the grid layout to work in IE10+ - this
    is quite a repetative syntax, so the mixin takes the number of items and the
    number of columns and works out the rest.
    
    Added comments to the pertinent parts of the navigation localisation to remind
    future people that they need to update the styles as well.
    injms committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    5c785b7 View commit details
    Browse the repository at this point in the history
  2. Update changelog

    injms committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    ca56385 View commit details
    Browse the repository at this point in the history