Add a linting rule to enforce 'use strict' #4020
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardTowers
force-pushed
the
lint-strict-mode
branch
from
3b09bcd
to
7d0f46c
Compare
richardTowers
force-pushed
the
eslint-standard
branch
from
7a4d2a3
to
e17cc72
Compare
richardTowers
force-pushed
the
lint-strict-mode
branch
from
7d0f46c
to
3a9c2e3
Compare
|
@richardTowers is this PR still needed? I think as we've now deployed the switch to |
|
Yep, no need for this now - it was just to identify which functions weren't already using strict mode, and they all will be now we're on type="module" 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR just to show where we're not using strict mode