-
Notifications
You must be signed in to change notification settings - Fork 13
svcop: Support for IAM Roles for EKS Service Accounts #931
Conversation
This comment has been minimized.
This comment has been minimized.
can we get some squashing + nicer commit messages please if this is ready for review 🙏 😄 |
charts/gsp-cluster/templates/02-gsp-system/service-operator/role.yaml
Outdated
Show resolved
Hide resolved
3f566b8
to
204d546
Compare
@@ -6,6 +6,16 @@ metadata: | |||
creationTimestamp: null | |||
name: {{ .Release.Name }}-service-operator-role | |||
rules: | |||
- resources: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible I was supposed to update config/rbac/role-not-patch.yaml
instead of add that kubebuilder:rbac comment earlier?
204d546
to
5a983ba
Compare
This comment has been minimized.
This comment has been minimized.
281f0b1
to
050266f
Compare
…roles Instead of via KIAM.
050266f
to
9558ca1
Compare
I am unable to run the full integration tests (hack/test_integration) since it looks like the RDS security group is invalid. I suspect this is because we have assumed it more static than it really is... I'm testing with fetching it by name now. we may want to tweak it as per following diff to make it more stable... diff --git a/components/service-operator/hack/test_integration.sh b/components/service-operator/hack/test_integration.sh
index 33072475..545d637d 100755
--- a/components/service-operator/hack/test_integration.sh
+++ b/components/service-operator/hack/test_integration.sh
@@ -1,6 +1,7 @@
#!/usr/bin/env bash
AWS_ACCOUNT_ID="$(aws sts get-caller-identity | jq -r .Account)"
+AWS_RDS_SECURITY_GROUP_ID=$(aws ec2 describe-security-groups | jq -r '.SecurityGroups[] | select(.GroupName == "sandbox_rds_from_worker") | .GroupId')
docker build \
--network host \
@@ -8,7 +9,7 @@ docker build \
--build-arg AWS_ACCESS_KEY_ID \
--build-arg AWS_SECRET_ACCESS_KEY \
--build-arg AWS_SESSION_TOKEN \
- --build-arg AWS_RDS_SECURITY_GROUP_ID=sg-04521d05ba3d9edb5 \
+ --build-arg AWS_RDS_SECURITY_GROUP_ID=$AWS_RDS_SECURITY_GROUP_ID \
--build-arg AWS_RDS_SUBNET_GROUP_NAME=sandbox-private \
--build-arg AWS_PRINCIPAL_PERMISSIONS_BOUNDARY_ARN=arn:aws:iam::${AWS_ACCOUNT_ID}:policy/sandbox-service-operator-managed-role-permissions-boundary \
--build-arg AWS_PRINCIPAL_SERVER_ROLE_ARN=arn:aws:iam::${AWS_ACCOUNT_ID}:role/sandbox_kiam_server \ |
Sounds like we should make a PR to fix hack/test_integration @chrisfarms ? |
yes, I'll make it after this is merged (since I already have the fix stashed) |
856d019
to
9f46b63
Compare
…plating for gsp-local
Creates Principal objects for ServiceAccounts labelled with the access group label, and updates the ServiceAccount with the appropriate annotation.