Bump turndown from 6.0.0 to 7.1.1 #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
dependencies
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/turndown-7.1.1
branch
from
cc4537e to
0a93dfc
Compare
Bumps [turndown](https://github.com/domchristie/turndown) from 6.0.0 to 7.1.1. - [Release notes](https://github.com/domchristie/turndown/releases) - [Commits](mixmark-io/turndown@v6.0.0...v7.1.1) --- updated-dependencies: - dependency-name: turndown dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/turndown-7.1.1
branch
from
0a93dfc to
e391fe9
Compare
Turndown 7 seems to resolve the problem that we added this extra code for. It caused the test to fail because it used a non-breaking space character rather than a regular space. Since we no longer need the code we should also remove the test.
|
There seems to be a problem with non-breaking spaces with this, which breakes the MS word comment removal test. I distilled it into a test locally: This fails with: Not too sure why though :-/ I imagine it's a similar problem to: mixmark-io/turndown#281 but I ran out of time looking at it. |
This deals with a part of turndown which is somewhat inelegant, if we
remove an element that starts or ends with a non-breaking space it will
be interpreted as trailing or leading whitespace of the node and
included in output. Rather than removed as one might expect.
For example:
```
const service = new TurndownService()
service.remove('span')
service.turndown('test <span><span><span>a </span>b </span>c </span>test')
=> 'test test'
service.turndown('test <span><span><span>a</span>b</span>c</span>test')
=> 'test test'
service.turndown('test <span><span><span>a </span>b </span>c </span>test')
=> 'test test'
```
This seems to be intentional changes to Turndown as per:
mixmark-io/turndown@27bdac0
though it is quite confusing.
This seems to be the case with Microsoft word comments that we want to
remove entirely, however they end up with a trailing non-breaking space
character.
This code adjusts the node at the point of conversion to remove any nbsp
whitespace. It wouldn't surprise me hugely if there were other problems
related to this that occur, but I can't think of any.
kevindew
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there's a problem with this release, see the comment below. We'll need to find some time to look into it - Kevin
Bumps turndown from 6.0.0 to 7.1.1.
Release notes
Sourced from turndown's releases.
Commits
d3022d37.1.19ad4c1bUpgrade rollup. Fix #387.b042d327.1.008ea6d6Add mixmark-io update info.c1b11a3Update deps.ef41a54Update SECURITY.md2d68b76Update SECURITY.mdb30d120Create SECURITY.md24070bcMerge pull request #372 from orchitech/npm-preparec11f982Fix build when used as git-linked dependency.Maintainer changes
This version was pushed to npm by martincizek, a new releaser for turndown since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)