PP-6147: Upgrade node to v12.4.1 #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardTowers
force-pushed
the
PP-6147-upgrade-node
branch
from
d5acde7 to
95fd4b8
Compare
This is the latest version of node supported by GOV.UK PaaS. We need to be on at least v12.9.0 to use AWS CloudFront's Field Level Encryption. The issue with `statsd` we encountered when we upgraded to node v12.13.1 (see [PP-5917](https://payments-platform.atlassian.net/browse/PP-5917)) looks like it's fixed in v12.4.1 (according to [the node release notes](https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V12.md#2020-01-07-version-12141-erbium-lts-bethgriggs)). **NOTE**: I'm not sure how to test that the statsd issue hasn't regressed, so this will need a look by someone with more understanding of the issue. The hash used in the Dockerfiles was obtained with: ``` $ docker pull node:12.14.1-alpine 12.14.1-alpine: Pulling from library/node c9b1b535fdd9: Pull complete 32eb17722c57: Pull complete c6a4a31e8940: Pull complete 3f01d5292e29: Pull complete Digest: sha256:1dd4309479f031295f3dfb61cf3afc3efeb1a991b012e105d1a95efc038b72f6 Status: Downloaded newer image for node:12.14.1-alpine docker.io/library/node:12.14.1-alpine ```
richardTowers
force-pushed
the
PP-6147-upgrade-node
branch
from
95fd4b8 to
76489e4
Compare
sfount
approved these changes
Feb 18, 2020
|
Confirming that See nodejs/node#30196 and https://github.com/nodejs/node/releases/tag/v12.14.1 |
|
Okay, lets |
then!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This is the latest version of node supported by GOV.UK PaaS. We need to
be on at least v12.9.0 to use AWS CloudFront's Field Level Encryption.
The issue with
statsdwe encountered when we upgraded to node v12.13.1(see PP-5917)
looks like it's fixed in v12.4.1 (according to the node release notes).
NOTE: I'm not sure how to test that the statsd issue hasn't
regressed, so this will need a look by someone with more understanding
of the issue.
HOW
Use your knowledge / testing to confirm this isn't going to break
things in production.