Rename pay-leave-for-parents question pages #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisroos
force-pushed
the
rename-pay-leave-for-parents-question-pages
branch
2 times, most recently
from
69fa766 to
92a5589
Compare
|
LGTM 👍 |
So that it matches the name of the question it contains.
So that it matches the name of the question it contains.
So that it matches the name of the question it contains.
So that it matches the name of the question it contains.
So that it matches the name of the question it contains.
So that it matches the name of the question it contains.
So that it matches the name of the question it contains.
So that it matches the name of the question it contains.
So that it matches the name of the question it contains.
So that it matches the name of the question it contains.
So that it matches the name of the question it contains.
So that it matches the name of the question it contains.
So that it matches the name of the question it contains.
So that it matches the name of the question it contains.
chrisroos
force-pushed
the
rename-pay-leave-for-parents-question-pages
branch
from
92a5589 to
0c9121d
Compare
|
I've rebased on master and force pushed in preparation for merging. |
chrisroos
added a commit
that referenced
this pull request
Oct 19, 2015
…uestion-pages Rename pay-leave-for-parents question pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're planning to migrate pay-leave-for-parents from Smartdown to Ruby in the near future.
We can use the
convert-smartdown-flow-to-smart-answer-flow.rbto automatically convert some of this Smart Answer, but it won't work for some of the more complicated conditionals. We'll need to convert those by hand and I think that having a one-to-one mapping between question page name (i.e. filename) and question will make that process easier.Expected changes