Make QuestionPresenterTest more realistic #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since phrase lists are now *only* interpolated for question nodes, these tests didn't make much sense. Especially as they were using the `QuestionPresenter` with an `Outcome` node. Also I'm not sure why the log statement was only being executed for outcome nodes. If anything the opposite is now true and in any case the code in `SmartAnswer::I18nRenderer#value_for_interpolation` will only ever be executed for question nodes.
|
Looks good to me. |
floehopper
added a commit
that referenced
this pull request
Nov 12, 2015
…ore-realistic Make QuestionPresenterTest more realistic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since phrase lists are now only interpolated for question nodes, these tests
didn't make much sense. Especially as they were using the
QuestionPresenterwith an
Outcomenode.Also I'm not sure why the log statement was only being executed for outcome
nodes. If anything the opposite is now true and in any case the code in
SmartAnswer::I18nRenderer#value_for_interpolationwill only ever be executedfor question nodes.
Expected observable changes