Remove deprecated Flow#section & #subsection_slug #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
Most of the code relating to these methods was removed in 2012 in the following two commits: * 8bee67e * d397d13 The deprecation warnings were left in place in case any un-merged flows used either of the methods. I think it's safe to say that this danger has passed and it's now safe to removed these methods.
floehopper
force-pushed
the
remove-unused-flow-section-slug-and-subsection-slug
branch
from
96d9b2a to
fd89ab7
Compare
|
I've rebased this against master and force-pushed in preparation for merging. |
floehopper
added a commit
that referenced
this pull request
Nov 16, 2015
…g-and-subsection-slug Remove deprecated Flow#section & #subsection_slug
floehopper
deleted the
remove-unused-flow-section-slug-and-subsection-slug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the code relating to these methods was removed in 2012 in the
following two commits:
The deprecation warnings were left in place in case any un-merged flows used
either of the methods. I think it's safe to say that this danger has passed and
it's now safe to removed these methods.
Expected observable changes